-
Notifications
You must be signed in to change notification settings - Fork 59
More details on the configuration file #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 88.03% 88.09% +0.06%
==========================================
Files 52 54 +2
Lines 2106 2142 +36
==========================================
+ Hits 1854 1887 +33
- Misses 252 255 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new command-line utility to display ITables configuration file location and contents, accessible via python -m itables.show_config. It also improves error handling in the configuration loading process.
- Adds a new
show_configmodule with functionality to display configuration file location and parsed options - Enhances error handling in
load_config_filewith more descriptive error messages for parsing and validation failures - Updates documentation to inform users about the new configuration inspection command
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/itables/show_config.py | New module implementing the show_config functionality |
| src/itables/config.py | Enhanced error handling with try-catch blocks and descriptive error messages |
| src/itables/init.py | Exports the config module for public API access |
| tests/test_show_config.py | Test coverage for the new show_config functionality |
| tests/test_config.py | Added test for improved error handling and removed duplicate fixture |
| tests/conftest.py | Moved shared fixture to conftest for reuse across test modules |
| docs/options/options.md | Documentation update explaining the new show_config command |
| docs/py/options/options.py | Documentation update in Python format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
80a5490 to
b5e5685
Compare
The location and content of the ITables configuration file corresponding to a given directory is given by
python -m itables.show_config.