-
Notifications
You must be signed in to change notification settings - Fork 59
Turn tomli into an optional dependency #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the tomli library an optional dependency instead of a required one to resolve conda package issues. The change allows ITables to function without TOML config file support when tomli is unavailable.
- Move
tomlifrom core dependencies to optionalconfigextra - Add graceful fallbacks when TOML parsing is unavailable
- Update version to 2.5.1 with changelog entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Moves tomli from dependencies to optional config extra |
| src/itables/config.py | Adds fallback handling when tomllib/tomli are unavailable |
| src/itables/version.py | Bumps version to 2.5.1 |
| docs/changelog.md | Documents the change in version 2.5.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (91.39%) is below the target coverage (93.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 94.22% 94.12% -0.10%
==========================================
Files 43 43
Lines 1869 1873 +4
==========================================
+ Hits 1761 1763 +2
- Misses 108 110 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
My attempt to add
tomlias a (conditional) dependency to the conda package failed at https://github.com/mwouts/itables-feedstock/, so I will make it an optional dependency instead.