Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented Aug 31, 2025

My attempt to add tomli as a (conditional) dependency to the conda package failed at https://github.com/mwouts/itables-feedstock/, so I will make it an optional dependency instead.

@github-actions
Copy link

github-actions bot commented Aug 31, 2025

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation.
Download it here, unzip it and then run pip install itables-xxx.whl in the unzipped directory.

@mwouts mwouts requested a review from Copilot August 31, 2025 21:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the tomli library an optional dependency instead of a required one to resolve conda package issues. The change allows ITables to function without TOML config file support when tomli is unavailable.

  • Move tomli from core dependencies to optional config extra
  • Add graceful fallbacks when TOML parsing is unavailable
  • Update version to 2.5.1 with changelog entry

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Moves tomli from dependencies to optional config extra
src/itables/config.py Adds fallback handling when tomllib/tomli are unavailable
src/itables/version.py Bumps version to 2.5.1
docs/changelog.md Documents the change in version 2.5.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.12%. Comparing base (7829cb5) to head (f60135c).

Files with missing lines Patch % Lines
src/itables/config.py 50.00% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (91.39%) is below the target coverage (93.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   94.22%   94.12%   -0.10%     
==========================================
  Files          43       43              
  Lines        1869     1873       +4     
==========================================
+ Hits         1761     1763       +2     
- Misses        108      110       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts mwouts merged commit 0960e88 into main Aug 31, 2025
14 checks passed
@mwouts mwouts deleted the version_2.5.1 branch August 31, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants