feat(space): add TMDB search composer - #2807
Conversation
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc646efb50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| contextReceipt(context) | ||
| } | ||
|
|
||
| ForEach(store.selectedLinks) { preview in |
There was a problem hiding this comment.
Rendering only selectedLinks makes the receipt's remove action irreversible for URLs that remain in the draft: toggleLink marks such a link unselected, the row immediately disappears, and selectionOverrides keeps it unselected even if the text is edited or the URL is retyped. This also hides previously unselected links when editing an entry, so users have no UI path to attach them again; render all detected links with their selection state or provide another reselection control.
Useful? React with 👍 / 👎.
| let candidates = try await service.refCandidates(search: contextSearch) | ||
| if generation == contextGeneration { | ||
| contextCandidates = candidates | ||
| contextCandidates = candidates.filter { candidate in | ||
| contextKindFilter == nil || candidate.kind == contextKindFilter | ||
| } |
There was a problem hiding this comment.
For /post, /note, /page, and /recently, this filters only the mixed result set already capped by refCandidates (12 by default). DatabaseService.findRefCandidates globally sorts and slices all content types before returning, so if newer matches of other types fill that limit, this command displays no results even when matching items of the requested kind exist. Pass the kind to the endpoint/query so filtering happens before the limit rather than filtering the truncated client response.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Notes
The local test environment could not perform a live external TMDB request; the request and normalization path is covered by focused Core and SpaceCore tests.
Superseded by a clean release PR because an unrelated concurrent CLI version-bump commit entered the original head branch.