-
Notifications
You must be signed in to change notification settings - Fork 41
Initial work an adapting AbstractLims and integration with SSO - Part 1 #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b1567b
to
39fdaaa
Compare
459a230
to
f4a4cf3
Compare
axelboc
reviewed
Nov 25, 2024
res["selectedProposalID"] = HWR.beamline.session.proposal_id | ||
else: | ||
raise Exception("Not logged in") | ||
logging.getLogger("MX3.HWR").warning("Logged out") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this warning needed? Could be an info instead. Seems to be logged twice too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it should be an info :)
86fc6e3
to
11d3a4d
Compare
73e4a67
to
77d2f2a
Compare
77d2f2a
to
87ad38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
mxcubeweb
part of theAbstractLims
PR onmxcubecore
: mxcube/mxcubecore#1079.As with PR #1079 on
mxcubecore
this work will need to be continued with some further cleanup. As with the work onmxcubecore
this is really a larger set of commits many also done by @antolinos and some by myself. There have been some cleanup after testing but apart from that this is code have been tested together with #1079.This PR introduces:
Testing
ISPyBMockupClient
(lims.xml
in demo environment) can be used to test both user type and proposal type login by setting theloginType
attribute.UI updates

Listing currently available sessions, and the possibility to explicitly reschedule and/or move a session from one beamline to another
Possibility to select from which LIMS to retrieve sample information from, data is uploaded to both DRAC and ISPyB