Skip to content

[GPhL] Add possibility to handle textarea #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

jbflo
Copy link
Member

@jbflo jbflo commented Apr 4, 2025

change default nested ternary rendering

)
) : rowKey === 'reffiles' ? (
// Specific textarea for "reffiles"
schema.properties.reffiles.type === 'textarea' && (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This textarea case is here cause of it's future specificity
it will have some regex for multi-line url validation in the future by @rhfogh

Copy link
Contributor

@rhfogh rhfogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables the advanced add-reference-mtz-file feature for GPhL workflow in interactive operation. It has been tested in mock mode.
Thanks @jbflo for adding it.

fix default nested ternary rendering

Fix textarea typo
@marcus-oscarsson marcus-oscarsson merged commit ac353c8 into develop Apr 9, 2025
17 checks passed
@marcus-oscarsson marcus-oscarsson deleted the jb-develop-gphl branch April 9, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants