Skip to content

Transform to Function Component (Sample List #3 ) #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

jbflo
Copy link
Member

@jbflo jbflo commented Apr 8, 2025

this is a big file we can always do further clean up and extract some component later.
But for now to keep it simple i just transform to functional component

  • remove bind(this)
  • removed this. and this.props
  • [Remove mapping options] when applying fitter

@jbflo jbflo force-pushed the jb-develop-sg-3 branch from bea2965 to 51665f7 Compare April 8, 2025 15:06
Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, so glad to see this class component go! 🎉

@jbflo jbflo force-pushed the jb-develop-sg-3 branch 2 times, most recently from 7b06baa to 38e77f7 Compare April 8, 2025 16:07
@jbflo jbflo force-pushed the jb-develop-sg-3 branch 2 times, most recently from 4d00225 to b6cd6b6 Compare April 9, 2025 09:58
@marcus-oscarsson
Copy link
Member

Awesome, so glad to see this class component go! 🎉

Same here ;) 👍

@marcus-oscarsson marcus-oscarsson merged commit bd609c6 into develop Apr 9, 2025
17 checks passed
@marcus-oscarsson marcus-oscarsson deleted the jb-develop-sg-3 branch April 9, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants