Client response muxer #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a single subscription response router. This means all client RPC requests will share one single subscription. This works by subscribing to
<base-uuid>.*. Every time we send an RPC request, we store a new random<request-uuid>in a map, and set the reply inbox as<base-uuid>.<request-uuid>. Now, a single thread can pull messages from the wildcard subscription and signal to other waiting threads that their message is ready to be consumed.There is a bit more plumbing required to make this work, but if this work successfully and fast on both jruby and MRI, we can remove our jruby specific jnats client and the custom subscription pool stuff that we added a few years back. That would be a huge win.
Old jruby client single threaded test:
New muxed client on jruby (not using jnats):
I'm not entirely sure where the magical speedup is coming from at this point. I guess it's good to know that things appear to be working well on jruby without jnats.
MRI:
Old version:
New version:
New version is reporting a little slower, but I don't think it's a substantial impact. I guess I'm more confused by the bench results than anything.
Few other things: