Change "in" Condition Rendering - Render With Empty Lists #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will force an empty list condition to render by default - which will cause an SQLException. After much discussion and many issues, we decided this was the safest approach.
These conditions will not render if empty regardless of configuration settings. This is consistent with the other "when present" conditions.
With this change, the "in" conditions will always render. The "in when present" conditions will only render if the input collection is non-null and contains at least one non-null value.
This reverts commit 5e9ed3d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potentially breaking change. The "in" conditions will now render even if the list of input values is empty. This will cause a runtime exception for invalid SQL. This change is made out of an abundance of caution after many issues have been raised about it.
For example see #228, #509, #752, #788
Resolves #788