Skip to content

fix(iOS): pass serverCallbackArgs when templateId is not provided #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hahnlee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(iOS): pass serverCallbackArgs when templateId is not provided #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/share/ios/RNCKakaoShareManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,11 @@ import SafariServices
} else if var defaultTemplate {
do {
let templatable = try generateTemplatable(templateType, &defaultTemplate)
ShareApi.shared.shareDefault(templatable: templatable, completion: shareCompletion)
ShareApi.shared.shareDefault(
templatable: templatable,
serverCallbackArgs: serverCallbackArgs,
completion: shareCompletion
)
} catch {
RNCKakaoUtil.reject(reject, error)
}
Expand Down Expand Up @@ -286,7 +290,10 @@ import SafariServices
do {
let templatable = try generateTemplatable(templateType, &defaultTemplate)

if let url = ShareApi.shared.makeDefaultUrl(templatable: templatable) {
if let url = ShareApi.shared.makeDefaultUrl(
templatable: templatable,
serverCallbackArgs: serverCallbackArgs
) {
let safariViewController = SFSafariViewController(url: url)
safariViewController.modalTransitionStyle = .crossDissolve
safariViewController.modalPresentationStyle = .overCurrentContext
Expand Down