for static build export kissfft as a private lib#137
Closed
oe1rsa wants to merge 1 commit into
Closed
Conversation
When statically linking to liblimesuiteng one also needs to link against the kissft lib. Since the user may or may not have installed kissfft as a static lib, we provide a private version which is linked as liblimesuiteng-kissfft-float.a when linking against liblimesuiteng. When the user also has installed the upstream kissfft she may link against this version, but then the results become dependent on where the both libraries appear on the linker line. Usually the first wins. So take care!
Member
|
dependency on kissfft.a has been removed by integrating it's source into limesuiteng.a b742fc6 |
Contributor
Author
|
Thank you! Works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When statically linking to liblimesuiteng one
also needs to link against the kissft lib.
Since the user may or may not have installed
kissfft as a static lib, we provide a private
version which is linked as liblimesuiteng-kissfft-float.a when linking against liblimesuiteng.
When the user also has installed the upstream
kissfft she may link against this version, but
then the results become dependent on where the
both libraries appear on the linker line.
Usually the first wins. So take care!
This pull request will resolve issue #131