Conversation
The reason why includes are failing is because the GLEW include directories might not be in the system ones (as it is typically installed via Homebrew). The way CMake code was structures it was linking directly to the GLEW library (instead of using imported target or using the GLEW_LIBRARIES), and it was not using GLEW_INCLUDE_DIRS. This change makes it so limeGUI is linked against GLEW::GLEW imported target which makes it so the GLEW include directories are configured for the limeGUI. For the case when system-wide GLEW is not installed an imported target is created from the compiled GLEW library. Tested both scenarios (GLEW available and is not available) by commenting out find_package(GLEW) and doing a full clean build.
Fix GUI compilation error on macOS with system GLEW
This fixes interaction with OpenGL graphs used, for example, in the FFT View module of the LimeSuiteGUI. This includes: - Zoom in by mouse-drag, where the zoom border used to be using wrong coordinates. - Panning, which used to happen at half the mouse speed. - Adding markers, which used to be added at a wrong location. The issue was happening on the macOS with Retina displays. This is a port of myriadrf/LimeSuite@49880e7f865 from the original LimeSuite repository.
When the Lime Suite GUI is used on a macOS which is default to the dark mode the information logged into the log window was hard to read: it was defaulting to the black foreground. The behavior now matched when no SetDefaultStyle() used at all: the light theme will use black text, and the dark theme will use the white color. The limitation this change does not address is the update of the colors in the log window when the theme is changed between dark ans light while the limeGUI is running. This is a port of myriadrf/LimeSuite@884070e490a and myriadrf/LimeSuite@cc09db1f9b0 from the LimeSuite repository.
Fixes for the macOS retina display and dark theme
…the internal glew library causing linking errors. Regressed by #114 Linking errors were not triggered while libglew-dev was installed on the system.
…ent. Avoids errors when LimeSuiteNG is included as cmake subproject
* Use CalibrationFlag enum for channel configuration The configuration field for calibration has changed from bool to CalibrationFlag in some previous commit, but some code was still assigning it as if it is boolean. In places where calibration was not needed it is a simple change to CalibrationFlag::NONE. In other cases use DCIQ calibration as it seems to be the one which was actually performed in those cases prior to the change of the configuration.
…r enable order. On PCIe, DMA enable -> Stream enable -> DMA disable -> Stream Disable. If stream gets disabled while DMA is active, DMA will not complete and software gets stuck waiting for completion. On USB, USB start transfers -> Stream enable -> Stream disable -> USB cancel transfers. If Stream is disabled after USB transfers are stopped, there will be residual data left in USB chip buffers, it needs to be flushed, otherwise on the next Stream enable, old data will be returned.
Without timeout software would get stuck waiting for data if hardware clocks failed to configure and does not produce data
…not being consumed.
…tarts, so that when using multiple devices theirs stream start as close as possible
…and source block configuration parameter tables.
…gin conda recipe.
…d package install steps.
Gnuradio-limesuiteng plugin blocks & CLI tools description update
✅ Deploy Preview for limesuiteng canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.