[Hackney] Route tree reports based on asset owner attribute #5726
+273
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5726 +/- ##
==========================================
- Coverage 82.60% 82.57% -0.03%
==========================================
Files 455 455
Lines 35401 35423 +22
Branches 5751 5759 +8
==========================================
+ Hits 29242 29251 +9
- Misses 4477 4486 +9
- Partials 1682 1686 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mysociety-pusher
force-pushed
the
FD-5187-hackney-trees-route-by-owner
branch
from
c40f899 to
21d65d2
Compare
dracos
requested changes
Nov 7, 2025
Member
dracos
left a comment
dracos
left a comment
There was a problem hiding this comment.
This all looks good, nice solution; couple of tiny suggestions is all
dracos
approved these changes
Nov 7, 2025
Add tree-aware email routing for Hackney that directs tree reports to different departments based on the tree asset owner (Housing, Highways, Parks, etc.). Introduces a generic split email parser that handles both the existing park/estate/other format and new tree owner formats. Refactors _split_emails to use the new generic _parse_split_emails method while maintaining backwards compatibility. Updates validate_contact_email to support both routing formats.
mysociety-pusher
force-pushed
the
FD-5187-hackney-trees-route-by-owner
branch
from
5041128 to
3d8e62f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tree-aware email routing for Hackney that directs tree reports to different departments based on the tree asset owner (Housing, Highways, Parks, etc.). Introduces a generic split email parser that handles both the existing park/estate/other format and new tree owner formats.
Refactors _split_emails to use the new generic _parse_split_emails method while maintaining backwards compatibility. Updates validate_contact_email to support both routing formats.
Fixes https://github.com/mysociety/societyworks/issues/5163