Dumfries extra config #5771
Open
Dumfries extra config #5771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a contact_us_phone configuration to be used in place of contact_us_url. If contact_us_phone exists, will not check for contact_us_url so, if anyone decides they want both, will require a little more development, and possibly simplifying the template as feels a little 'tricky' at the moment. Tests in shropshire.t should demonstrate the previous state still working. mysociety/societyworks#5226
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dumfries-reviewed #5771 +/- ##
=====================================================
+ Coverage 82.60% 82.62% +0.01%
=====================================================
Files 458 458
Lines 35697 35693 -4
Branches 5814 5814
=====================================================
+ Hits 29488 29491 +3
+ Misses 4517 4510 -7
Partials 1692 1692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MorayMySoc
commented
Dec 11, 2025
| [% ELSE %] | ||
| call us on: [%~ c.cobrand.feature('contact_us_phone') %] | ||
| [% END %] | ||
| </p> |
Contributor
Author
There was a problem hiding this comment.
Just realised I could remove the ~ and the non-breaking space and this should be the same
davea
approved these changes
Dec 16, 2025
Member
|
Branch in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change homepage placeholder text - fixes: https://github.com/mysociety/societyworks/issues/5225
Contact and privacy information - https://github.com/mysociety/societyworks/issues/5226
Please also check: dumfries-categories-and-config in server repo for:
Categories mapping https://github.com/mysociety/societyworks/issues/5254
Display asset layers from https://github.com/mysociety/societyworks/issues/5255
[skip changelog]