[Central Beds] Update cobrand for migration to Aurora. #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neprune
force-pushed
the
cbd-aurora
branch
2 times, most recently
from
c273fb4 to
21b6b3a
Compare
neprune
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cbd-aurora-reviewed #5784 +/- ##
====================================================
Coverage 82.64% 82.64%
====================================================
Files 457 457
Lines 35716 35705 -11
Branches 5822 5818 -4
====================================================
- Hits 29516 29509 -7
+ Misses 4501 4499 -2
+ Partials 1699 1697 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove logic that was specific to Symology Insight and generally tidy up.
Symology's new Aurora backend supports uploading files, so send files to open311-adapter as uploads so it doesn't have to fetch them from FMS.
dracos
requested changes
Jan 8, 2026
Member
dracos
left a comment
dracos
left a comment
There was a problem hiding this comment.
I think we need to keep some things that have been removed, unless I've misunderstood.
| } | ||
|
|
||
| my $open311_only = [ | ||
| { name => 'title', |
Member
There was a problem hiding this comment.
Both these are used by the Jadu open311-adapter code?
| $params->{service_request_id_ext} = $comment->problem->id; | ||
|
|
||
| my $contact = $comment->problem->contact; | ||
| $params->{service_code} = $contact->email; |
Member
There was a problem hiding this comment.
We need to include the service code, so that open311-adapter Multi knows which backend to send it to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing logic that we should no longer need and generally tidying up. Relates to https://github.com/mysociety/societyworks/issues/5288 and https://github.com/mysociety/societyworks/issues/5289.
[skip changelog]