Allow superusers to change body of failed reports #5786
+146
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the body name on the admin report edit page with a dropdown, allowing superusers to change the destination body for a failed report. This is intended primarily for the situation where a report has been associated with the wrong body when created (e.g. some NH reports on FMS.com) and needs manually changing to the correct body. Deliberately limited in scope, the dropdown only appears for reports that: - haven't yet been sent, - have failed to send at least once, - are for a single body, and - are at a location that has another body they can be asssigned to. Any changes made are added to the admin log for the report.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5786 +/- ##
==========================================
- Coverage 82.64% 82.63% -0.01%
==========================================
Files 457 457
Lines 35716 35728 +12
Branches 5822 5826 +4
==========================================
+ Hits 29516 29524 +8
- Misses 4501 4502 +1
- Partials 1699 1702 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the body name on the admin report edit page with a dropdown, allowing superusers to change the destination body for a failed report.
This is intended primarily for the situation where a report has been associated with the wrong body when created (e.g. some NH reports on FMS.com) and needs manually changing to the correct body.
Deliberately limited in scope, the dropdown only appears for reports that:
Any changes made are added to the admin log for the report.
[skip changelog]