Waste nicer mobile view #5793
Waste nicer mobile view #5793
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5793 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 458 458
Lines 35802 35802
Branches 5844 5844
=======================================
+ Hits 29594 29596 +2
+ Misses 4506 4505 -1
+ Partials 1702 1701 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
force-pushed
the
waste-nicer-mobile-view-v2
branch
from
6566bf7 to
b65586f
Compare
| </h3> | ||
| <div class="govuk-grid-row"> | ||
| <div class="govuk-grid-column-one-quarter text-centered"> | ||
| <div class="govuk-grid-column govuk-grid-column-always-one-quarter text-centered"> |
There was a problem hiding this comment.
I also changed bexley and bromley services_extra - should these presumably also be changed to match your changes?
There was a problem hiding this comment.
I've pushed a fixup commit that I think matches the changes if you'd like to check
| [% ELSE %] | ||
| <div class="govuk-grid-column-full"> | ||
| [% IF c.cobrand.moniker == 'peterborough' %] | ||
| <h3 id="[% unit.service_name %]" class="govuk-heading-m waste-service-name">[% unit.service_name %]</h3> |
There was a problem hiding this comment.
(easier to see with whitespace changes ignored) This is lost for a service in Peterborough that doesn't have an image, there's now no heading at all; presumably is okay to leave this in?
There was a problem hiding this comment.
Have added fe86ccb to put this back, if you could check that also
The image can always be put inline with the collection dates, and we can make the services full width until a wider point. [Bexley] Fixes issue with missing margins on garden waste entry.
Reordered elements such as title and images, this should improved how the image is rearranged on mobile, so it seats next to the title. For Peterborough we have mantain the same layout.
- Increased `margin-top` for "Your collections" so there is a clearer separations with the address section. - Removed border-bottom from `waste-service-name`
dracos
force-pushed
the
waste-nicer-mobile-view-v2
branch
from
b65586f to
97337b9
Compare
|
Thank you Matthew I will check it out |
Fixes part of: #5730
This PR Implements the changes mentioned in here:
@dracos In ended up having to make some changes to the nesting/structure of the HTML, because just overriding the govuk classes for their grid/layout system wasn't going to be enough to accomplish the layout we wanted.
Just in case the second commit is entirely optional and we can drop it.
Preview
Screen.Recording.2025-12-23.at.11.01.05.mov
Screen.Recording.2025-12-23.at.11.59.37.mov
Screen.Recording.2025-12-23.at.11.00.27.mov
Screen.Recording.2025-12-23.at.12.00.24.mov
[skip changelog]