Skip to content

Conversation

@nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Jan 2, 2026

Visibility can be toggled, similar to /admin/body/ page.

Fixes https://github.com/mysociety/societyworks/issues/5187.

Changes include:

  • When on 'Category' or 'Category and state' tab
    • JS-generated button to toggle visibility of categories with no reports
    • JS-generated button to toggle visibility of deleted categories
    • Buttons do not appear when 'category' filter used
      • Instead, only the selected categories are displayed
    • Respective buttons do not appear if no zero-report categories or no deleted categories
    • If JS disabled, zero-report and deleted categories are still highlighted
    • Special handling of 'Multiple' grouping

@nephila-nacrea nephila-nacrea changed the title Hide deleted categories on dashboard page Hide deleted and 'zero' categories on dashboard page Jan 2, 2026
@nephila-nacrea nephila-nacrea self-assigned this Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (a0a71d2) to head (efa13e0).

Files with missing lines Patch % Lines
perllib/FixMyStreet/App/Controller/Dashboard.pm 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5796      +/-   ##
==========================================
- Coverage   82.64%   82.63%   -0.01%     
==========================================
  Files         457      457              
  Lines       35714    35725      +11     
  Branches     5821     5822       +1     
==========================================
+ Hits        29517    29523       +6     
- Misses       4499     4503       +4     
- Partials     1698     1699       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nephila-nacrea nephila-nacrea force-pushed the dashboard-hide-deleted-and-zeroes branch from 9b15e7a to 99629b1 Compare January 2, 2026 18:30
@nephila-nacrea nephila-nacrea force-pushed the dashboard-hide-deleted-and-zeroes branch 2 times, most recently from 5683613 to 8b12e6e Compare January 6, 2026 11:42
@nephila-nacrea nephila-nacrea requested a review from neprune January 6, 2026 11:43
@nephila-nacrea nephila-nacrea force-pushed the dashboard-hide-deleted-and-zeroes branch from 8b12e6e to efa13e0 Compare January 6, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants