[Third PR 🐵] Allow group to be updated alongside category on report edit/inspect forms #5806
+380
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5806 +/- ##
==========================================
- Coverage 82.61% 82.52% -0.10%
==========================================
Files 458 460 +2
Lines 35768 36266 +498
Branches 5831 5930 +99
==========================================
+ Hits 29551 29929 +378
- Misses 4515 4630 +115
- Partials 1702 1707 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nephila-nacrea
changed the title
nephila-nacrea
changed the title
nephila-nacrea
force-pushed
the
handle-group-with-category-selection
branch
from
feff193 to
4524ea6
Compare
JS is used to update response template and priority options whenever the category is changed in the report inspect form. These need to take into consideration that category strings are not of the form 'group__category'. JS is also used for duplicate lookup, but it turns out this does not use the form category.
nephila-nacrea
force-pushed
the
handle-group-with-category-selection
branch
from
4524ea6 to
19501a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mysociety/societyworks/issues/4639.
Another PR for
handle-group-with-category-selectionas yet another bug, where response templates were not being picked up in JS.Previous two: #5777, #5800.