Apply style image report first to all cobrands #5809
+158
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduced size "Start report with a photo" button - Reduced size and intensity of `box-shadow` for "Start report with a photo" button - Added $report-forms-wrapper-margin-top variable - Improved dropzone hover effect when JS is not enable - Improved color contrast of mobile start a report button, by using the same variables as primary button does. - Apply `bttn--primary` style to submit iamge button in front page
Problem: With the image report first, the message was being displayed between the postcode form and the image report form. With this commit the message has been moved out side of `report-forms-wrapper`
lucascumsille
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## photo-first-frontend-cobrands #5809 +/- ##
==============================================================
Coverage 82.65% 82.65%
==============================================================
Files 458 458
Lines 35875 35875
Branches 5857 5857
==============================================================
Hits 29651 29651
Misses 4518 4518
Partials 1706 1706 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/mysociety/societyworks/issues/5341
@dracos I included a commit that moves the
front-main-messageoutside thepostcode-form-box. I noticed we had problems with North Northants:Preview for all cobrands in this drive folder
[skip changelog]