WIP Fd6151 kingston non actionable missed #5813
Draft
+833
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Kingston are using escalations move the escalation code out of the Sutton cobrand and into the shared Role
This is used by the escalation code to check if there's an existing event that could be escalated
This currently assumes everthings works the same as Sutton
Kingston and Sutton have different container escalation windows so move the configuration for the window to a function in the Cobrand
Update waste_escalation_window to be more flexible so all the escalation data is in one place.
nephila-nacrea
changed the base branch from
master
to
5258-kingston-escalation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 5258-kingston-escalation #5813 +/- ##
============================================================
+ Coverage 82.63% 82.82% +0.19%
============================================================
Files 458 459 +1
Lines 35791 37470 +1679
Branches 5841 6165 +324
============================================================
+ Hits 29576 31035 +1459
- Misses 4515 4720 +205
- Partials 1700 1715 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]