Front end string translation #524
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
516-front-end-string-translation
branch
from
48abbf5 to
dec690f
Compare
struan
force-pushed
the
515-language-switcher
branch
from
b3ebf3a to
420ada1
Compare
struan
force-pushed
the
516-front-end-string-translation
branch
from
1e599d9 to
644f8ef
Compare
struan
changed the base branch from
515-language-switcher
to
509-welsh-translation-staging
struan
force-pushed
the
516-front-end-string-translation
branch
3 times, most recently
from
6cb7ce5 to
0273cb9
Compare
struan
force-pushed
the
509-welsh-translation-staging
branch
from
420ada1 to
15b5a28
Compare
Note that some of the strings for this page are in votingarea.php which is where xgettext finds them. However, they end up getting passed through gettext again here because they are held in data structures that get parsed before the locale is set. That's why there are things like `$v['rep_name'] = _($va_rep_name[$vat]);` in the code.
Adds translations on the compose, preview and confirmation email sent pages
This uses parsedown for the longer answers to hopefully make it a bit easier to translate as you don't need to wrap things in p tags
struan
force-pushed
the
516-front-end-string-translation
branch
from
f4d316c to
cfeed17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all the strings in the front end and wraps them in gettext calls for translation.
In general I've gone with the theory of more context is better over excluding HTML so some of these include quite a bit of HTML which I think is reasonable, especially where the text is linked. I've also tried to extract things that might change, e.g URLs with tracking codes, to avoid small changes requiring recompiling the translations.
For longer bits of text it passes things through Parsedown to strip out lots of p tags.
It does not translate the stats pages, the fictional postcodes page and the overseas correspondence pages.
Fixes #516