test: add reproduction test for multi-statement query placeholder expansion#25
Draft
mdierolf wants to merge 1 commit into
Draft
test: add reproduction test for multi-statement query placeholder expansion#25mdierolf wants to merge 1 commit into
mdierolf wants to merge 1 commit into
Conversation
…ansion Adds a failing test case demonstrating an issue where an object passed to `SET ?` in a secondary statement in a multi-statement query is incorrectly formatted (resulting in an unintended `[object Object]` string), rather than being expanded properly into key-value pairs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a failing test case demonstrating an issue where an object passed to
SET ?in a previous statement in a multi-statement query is incorrectly formatted (resulting in an unintended[object Object]string), rather than being expanded properly into key-value pairs.The failing code:
format("SET @foo = 1; INSERT INTO bar SET ?", [{ foo: 'bar' }]);Expected:
SET @foo = 1; INSERT INTO bar SET foo = 'bar'Result:
SET @foo = 1; INSERT INTO bar SET '[object Object]'