Skip to content

impl From<cc::Build> for cpp_build::Config #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

impl From<cc::Build> for cpp_build::Config #111

merged 1 commit into from
May 3, 2024

Conversation

ian-h-chamberlain
Copy link
Contributor

Closes #110

Pretty simple, just added a From which does what new() did before, and swap new() to use the new impl.

ogoffart
ogoffart approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogoffart ogoffart merged commit 58c8c46 into mystor:master May 3, 2024
2 of 10 checks passed
@ian-h-chamberlain ian-h-chamberlain deleted the feat/from-cc-build branch May 3, 2024 21:51
@ian-h-chamberlain ian-h-chamberlain mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easier conversion from cc::Build to cpp_build::Config ?
2 participants
@ian-h-chamberlain @ogoffart