🐛 Fixed issue: removed re-open of the keyboard after pincode set #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here is no biometic available for the device.
👷 Deploy request for mtw-opensource pending review.Visit the deploys page to approve it
|
👷 Deploy request for mtw-giveaway pending review.Visit the deploys page to approve it
|
👷 Deploy request for mytonwallet-tma pending review.Visit the deploys page to approve it
|
|
Could you please update this PR and exclude unrelated changes (this commit) |
Sina-KH
suggested changes
Oct 16, 2025
Sina-KH
left a comment
Sina-KH
left a comment
There was a problem hiding this comment.
Please check my comment. The fix itself looks nice. 👍
Author
Yep, my bad, done! |
Author
|
This PR was closed, due to it's been created from wrong branch, that stucks me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: removed re-open of the keyboard after pincode set if there is no biometic available for the device.
Why it solves:
After passcode is confirmed and user don't have biometrics available, the keyboard was closed and this part was triggered.
Since passcode was confirmed and we are still on this page - passcodeInputView.requestFocus() was triggered.
Now this both pop() and passcodeInputView.requestFocus() only triggered only before passcodeConfirmed