🐛 Fixed issue: laggy animation of MARQUEE ellipsize text. #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated RecyclerView so it's no longer re-creates all the view every update from JS Bridge. Used DiffUtil to calculate diff and make updates only for changed ones.
👷 Deploy request for mytonwallet-tma pending review.Visit the deploys page to approve it
|
👷 Deploy request for mtw-opensource pending review.Visit the deploys page to approve it
|
👷 Deploy request for mtw-giveaway pending review.Visit the deploys page to approve it
|
Sina-KH
reviewed
Oct 16, 2025
| override fun isSame(comparing: WEquatable<*>): Boolean { | ||
| return if (comparing is EarnItem && comparing::class == this::class) { | ||
| comparing.timestamp == timestamp && comparing.amount == amount | ||
| comparing.timestamp == timestamp && comparing.amount == amount && comparing.amountInBaseCurrency == amountInBaseCurrency |
There was a problem hiding this comment.
isSame should compare identifiers (or similar unique properties) to check if two instances refer to the same item. Comparing amountInBaseCurrency shouldn't be necessary here.
Sina-KH
reviewed
Oct 16, 2025
|
|
||
| val diffResult = DiffUtil.calculateDiff(diffCallback) | ||
| previousHistoryItems = newItems.toList() // Store copy for next comparison | ||
| diffResult.dispatchUpdatesTo(rvAdapter) |
There was a problem hiding this comment.
How about using List<WEquatable<*>>.diff and WRecyclerViewAdapter.applyChanges? Did you try to use that instead? It should be ready-to-use and probably easier to apply to all the necessary screens.
There was a problem hiding this comment.
Yes, thanks, didn't notice that utils. Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated RecyclerView so it's no longer re-creates all the view every update from JS Bridge. Used DiffUtil to calculate diff and make updates only for changed ones.
Alternative way to fix: The issue could be addressed at the ViewModel level first by reducing frequent state emissions, rather than introducing DiffUtil if that’s not the standard approach in the project.