-
Notifications
You must be signed in to change notification settings - Fork 11
Add read_file calls with prepared mem buffer. #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abel-msk
wants to merge
15
commits into
n-serrette:main
Choose a base branch
from
abel-msk:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution, I will look at it once I have a little time |
…s/chunks and process large files
Thanks for your work,
I will test and review your work further, if you do not consider your PRs ready for review could you mark them as draft Once again thanks for your work, your contribution is greatly apprecied. |
Hi.
Thanks for answer.
I made only one PR when I hadn't started fixing sd_file_server yet.
I thought subsequent fixes wouldn't go into the initial request.
Unfortunately, I'm not very good at making
two different requests from the final version. I'll try.
And Yes, I didn't test with Arduino framework, because my other code does not work with Arduino framework . But yes, I'll make small profile for testing and check.
… On 29 Apr 2025, at 19:27, Serrette Nicolas ***@***.***> wrote:
n-serrette
left a comment
(n-serrette/esphome_sd_card#22)
<#22 (comment)>
Thanks for your work,
I started looking at your PR, here are my first remarks:
split your work into two PR :
one for the addition of the new reading methods on sd_mmc_card
the other for the correction on of the file download on sd_file_server
remove the .sd_file_server.cpp.swp file which seams to be a remnant of your merge conflict issue
document the methods you added in sd_mmc_card/README.md
sd_file_server does not compile with the arduino framework
I will test and review your work further, if you do not consider your PRs ready for review could you mark them as draft
Once again thanks for your work, your contribution is greatly apprecied.
—
Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD3YOUFDI3CDVL24K5BM4QD236SA5AVCNFSM6AAAAAB3BB74NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZZGUZDCNJZHA>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I fix compile problems for Arduino, but unfortunately steel cannot test in real application.
And of course add new methods in README.
Copy descriptions here
sd_mmc_card
Newly added methods
Type file_ptr_t universal (IDF/Arduino) pointer to File object.
FILE
for IDF framework andfs::File
for Arduino frameworkfile_ptr_t open_file(const char path, const char mode);
file_ptr_t open_file(std::string const &path, const char *mode);
path - file path to open
mode - mode to open file ("r" - for read "w" - for write)
size_t block_read_file(file_ptr_t fl, uint8_t *buf, size_t promise_len);
fl - file handler
buf - pointer to memory area where to read data;
promise_len - max num bytes to read.
void close_file(file_ptr_t fl);
close file