WIP: refactor(cargo): use crate-type flag#259
Closed
decentral1se wants to merge 1 commit into
Closed
Conversation
b681584 to
869f820
Compare
869f820 to
e2c1a23
Compare
Contributor
|
@decentral1se did you end up not needing this anymore? |
Contributor
Author
|
@dignifiedquire oh i still need it as laid out in #258 and would be curious if any of you want to pick this up. i saw several CI failures which i can't really confirm the fix for due to lack of hardware for cross compiling. |
Contributor
|
got it, will take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #258.
I'm exploring the blast radius of this potential change 🙃