Skip to content

fix(release): regenerate iroh-js/index.js in prepare-release #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dignifiedquire merged 1 commit into from
Jul 11, 2026
Merged

fix(release): regenerate iroh-js/index.js in prepare-release #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,14 @@ cargo update -p iroh-ffi --precise "$VERSION" >/dev/null
echo "==> refresh iroh-js/yarn.lock"
( cd iroh-js && yarn install --mode update-lockfile >/dev/null )

# `napi build` regenerates iroh-js/index.js with the new version baked into
# every `bindingPackageVersion !== '<V>'` check + error message. Without this
# step, publish CI regenerates index.js on the runner and ships a fresh copy
# to npm — but the committed file on main stays stuck on the old literal,
# drifting further each release.
echo "==> regenerate iroh-js/index.js via napi build"
cargo make js-build >/dev/null

cat <<EOF

Prepared release v$VERSION (versions only; Swift xcframework SHA is CI's job).
Expand Down
Loading
Loading