Skip to content

deps: bump netwatch#4429

Open
Frando wants to merge 1 commit into
mainfrom
deps/bump-net-tools
Open

deps: bump netwatch#4429
Frando wants to merge 1 commit into
mainfrom
deps/bump-net-tools

Conversation

@Frando

@Frando Frando commented Jul 20, 2026

Copy link
Copy Markdown
Member

Description

Bumps netwatch to git main (to be released as netwatch 0.20).

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
  • This PR was created by a human that thought critically about the
    proposed change and wrote an as clear and concise description as
    they could.
  • This PR isn't slop, and is carefully crafted to do have the
    intented effect.

@github-actions

Copy link
Copy Markdown

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4429/docs/iroh/

Last updated: 2026-07-20T13:42:40Z

@github-actions

Copy link
Copy Markdown

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: d87870a

@n0bot n0bot Bot added this to iroh Jul 20, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh Jul 20, 2026

@flub flub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I expect this to break noq's patchbay tests since that has to patch in noq into here and deletes any patch section here. The patchbay noq CI script will have to become smarter.

Since patchbay tests on noq are required now, please try and fix this first on the noq side before merging. Otherwise everything in noq will be blocked on this.

Maybe we should switch to a tool like https://github.com/sen-ltd/toml-query instead of the sed stuff it does now.

(also, surprised that this didn't require any other changes)

@Frando

Frando commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

(also, surprised that this didn't require any other changes)

The only actual change since last release is n0-computer/net-tools#163, and while it is technically breaking, in reality it usually is not (it replaces netdev reexports with identically-shaped structs defined in netwatch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🚑 Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants