fix: loosen default context type #1393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 672d023 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
saihaj
approved these changes
May 12, 2022
YassinEldeeb
approved these changes
Dec 13, 2022
packages/types/src/context-types.ts
Outdated
| @@ -3,7 +3,7 @@ import { Plugin } from './plugin'; | |||
| import { Spread, TuplifyUnion, Unarray } from './utils'; | |||
|
|
|||
| // We are using `interface` instead of `type` in order to allow type augmentation | |||
| export interface DefaultContext extends Record<string | symbol | number, unknown> {} | |||
| export interface DefaultContext {} | |||
There was a problem hiding this comment.
Yeah, this's much cleaner. an empty interface already allows any keys and values by default
🚀 Website PreviewThe latest changes to the website are available as preview in: https://6655b5c1.envelop.pages.dev |
|
oh, that's weird. looks like the empty interface isn't behaving correctly. the CI fails with this error: error TS2339: Property 'storeId' does not exist on type 'Readonly<DefaultContext>'.which means it doesn't identify |
ardatan
force-pushed
the
main
branch
2 times, most recently
from
a23dec1 to
3ac13be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.