-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loosen default context type #1393
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 672d023 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/types/src/context-types.ts
Outdated
@@ -3,7 +3,7 @@ import { Plugin } from './plugin'; | |||
import { Spread, TuplifyUnion, Unarray } from './utils'; | |||
|
|||
// We are using `interface` instead of `type` in order to allow type augmentation | |||
export interface DefaultContext extends Record<string | symbol | number, unknown> {} | |||
export interface DefaultContext {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this's much cleaner. an empty interface already allows any keys and values by default
🚀 Website PreviewThe latest changes to the website are available as preview in: https://6655b5c1.envelop.pages.dev |
oh, that's weird. looks like the empty interface isn't behaving correctly. the CI fails with this error: error TS2339: Property 'storeId' does not exist on type 'Readonly<DefaultContext>'. which means it doesn't identify |
a23dec1
to
3ac13be
Compare
No description provided.