fix: Use language overlay and highlight functions#10
Conversation
yehorkardash
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I like the overall approach, but we're duplicating packages/@n8n/codemirror-lang/src/expressions/expressions.grammar. Should we move this entire repo codemirror-lang-n8n-sql to packages/@8n/codemirror-lang/src/sql?
There was a problem hiding this comment.
Yes, I can do that. Let's merge the PR here and I will move the repo
There was a problem hiding this comment.
If we're reverting to the original, let's refer to the latest?
There was a problem hiding this comment.
The latest changes require updating code mirror dependencies in editor-ui, because some interfaces were changed.
Not particularly a blocker, but I didn't want to increase the scope of the task
| for (let kw of keywords.split(" ")) if (kw) result[kw] = Keyword | ||
| for (let tp of types.split(" ")) if (tp) result[tp] = Type | ||
| for (let kw of (builtin || "").split(" ")) if (kw) result[kw] = Builtin | ||
| for (let kw of (functions || "").split(" ")) if (kw) result[kw] = Function |
There was a problem hiding this comment.
| for (let kw of (functions || "").split(" ")) if (kw) result[kw] = Function | |
| for (let fn of (functions || "").split(" ")) if (kw) result[kw] = Function |
2 participants
This PR makes some fixes related to n8n expression parsing and syntax highlighting.
Issues:
The issue with links is that expressions
{{ }}were included in SQL grammar and string parsing got broken. The PR reverts sql grammar to it's original state and adds an overlay language that separates sql from n8n expressions.The PR also adds a new element
Functionto allow highlighting them differently than statements such asSELECT. I tried to include the most basic functions, but in reality there are hundreds of functions in each SQL dialect, so it feasible to include them all.Related to n8n-io/n8n#19291