feat: add abort execution button to playground#23
Closed
tomi wants to merge 2 commits into
Closed
Conversation
The Run button transforms into a red Abort button during execution.
Clicking it (or pressing Ctrl+C) now calls DELETE /executions/{id}
to kill the server-side process, not just abort the HTTP stream.
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="playground/src/app.js">
<violation number="1" location="playground/src/app.js:260">
P1: Abort can miss server-side kill when pressed before `started` arrives, because DELETE is skipped if `currentExecId` is still null.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| currentAbortController.abort(); | ||
| appendOutput('^C', 'error'); | ||
|
|
||
| if (execId && sandboxId) { |
There was a problem hiding this comment.
P1: Abort can miss server-side kill when pressed before started arrives, because DELETE is skipped if currentExecId is still null.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At playground/src/app.js, line 260:
<comment>Abort can miss server-side kill when pressed before `started` arrives, because DELETE is skipped if `currentExecId` is still null.</comment>
<file context>
@@ -247,19 +248,58 @@ async function execInSandbox(sandboxId, command, timeoutMs = 300000, signal) {
+ currentAbortController.abort();
+ appendOutput('^C', 'error');
+
+ if (execId && sandboxId) {
+ const baseUrl = baseUrlInput.value.trim().replace(/\/+$/, '');
+ try {
</file context>
endor
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /sandboxes/{id}/executions/{exec_id}to kill the server-side process, instead of only aborting the HTTP fetch streamexec_idfrom thestartedevent so the correct execution can be targeted for cancellationKapture.2026-05-08.at.16.52.38.mp4
Test plan
sleep 60) and verify the button changes to red "Abort"killed: true)