Skip to content

chore: publish chart#84

Merged
endor merged 4 commits into
mainfrom
chore/publish-chart
May 28, 2026
Merged

chore: publish chart#84
endor merged 4 commits into
mainfrom
chore/publish-chart

Conversation

@endor

@endor endor commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Publish n8n sandbox service helm chart to GHCR so it can be used as a dependency.


Summary by cubic

Publishes the n8n-sandbox-service Helm chart to GHCR (OCI) and adds CI to validate version bumps and publish on merges to main. Other charts can now depend on it.

  • New Features
    • PR validation enforces semver and requires a chart version bump when chart files change.
    • Publish workflow (Helm 3.17.0) lints, packages, and pushes to oci://ghcr.io/<owner>/<repo> with concurrency to avoid overlapping runs.
    • Bumps chart version to 0.2.0.

Written for commit 45ae8b5. Summary will update on new commits.

Review in cubic

@cla-bot cla-bot Bot added the cla-signed label May 27, 2026
@blacksmith-sh

This comment has been minimized.

@endor endor requested a review from tomi May 27, 2026 13:15

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/release-helm-chart-validate.yml">

<violation number="1" location=".github/workflows/release-helm-chart-validate.yml:48">
P2: Version comparison only checks inequality, not whether the version is actually bumped up. A downgrade (e.g., 1.2.0 → 1.1.0) would pass validation, which can cause Helm release issues where an already-published higher version exists.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

exit 1
fi

if [ "$base_version" = "$head_version" ]; then

@cubic-dev-ai cubic-dev-ai Bot May 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Version comparison only checks inequality, not whether the version is actually bumped up. A downgrade (e.g., 1.2.0 → 1.1.0) would pass validation, which can cause Helm release issues where an already-published higher version exists.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/release-helm-chart-validate.yml, line 48:

<comment>Version comparison only checks inequality, not whether the version is actually bumped up. A downgrade (e.g., 1.2.0 → 1.1.0) would pass validation, which can cause Helm release issues where an already-published higher version exists.</comment>

<file context>
@@ -0,0 +1,54 @@
+            exit 1
+          fi
+
+          if [ "$base_version" = "$head_version" ]; then
+            echo "Chart changes must bump charts/n8n-sandbox-service/Chart.yaml version."
+            echo "Current version: $head_version"
</file context>
Fix with Cubic

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much effort. We trust developers to handle this correctly for now.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood—thanks for the context.

@endor endor requested a review from mfsiega as a code owner May 28, 2026 07:29
@endor endor merged commit 6a26fe5 into main May 28, 2026
9 checks passed
@endor endor deleted the chore/publish-chart branch May 28, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants