chore: publish chart#84
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release-helm-chart-validate.yml">
<violation number="1" location=".github/workflows/release-helm-chart-validate.yml:48">
P2: Version comparison only checks inequality, not whether the version is actually bumped up. A downgrade (e.g., 1.2.0 → 1.1.0) would pass validation, which can cause Helm release issues where an already-published higher version exists.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| exit 1 | ||
| fi | ||
|
|
||
| if [ "$base_version" = "$head_version" ]; then |
There was a problem hiding this comment.
P2: Version comparison only checks inequality, not whether the version is actually bumped up. A downgrade (e.g., 1.2.0 → 1.1.0) would pass validation, which can cause Helm release issues where an already-published higher version exists.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/release-helm-chart-validate.yml, line 48:
<comment>Version comparison only checks inequality, not whether the version is actually bumped up. A downgrade (e.g., 1.2.0 → 1.1.0) would pass validation, which can cause Helm release issues where an already-published higher version exists.</comment>
<file context>
@@ -0,0 +1,54 @@
+ exit 1
+ fi
+
+ if [ "$base_version" = "$head_version" ]; then
+ echo "Chart changes must bump charts/n8n-sandbox-service/Chart.yaml version."
+ echo "Current version: $head_version"
</file context>
Collaborator
Author
There was a problem hiding this comment.
Too much effort. We trust developers to handle this correctly for now.
There was a problem hiding this comment.
Understood—thanks for the context.
mfsiega
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish n8n sandbox service helm chart to GHCR so it can be used as a dependency.
Summary by cubic
Publishes the
n8n-sandbox-serviceHelm chart to GHCR (OCI) and adds CI to validate version bumps and publish on merges tomain. Other charts can now depend on it.oci://ghcr.io/<owner>/<repo>with concurrency to avoid overlapping runs.Written for commit 45ae8b5. Summary will update on new commits.
Review in cubic