Skip to content

Conversation

vignesh1507
Copy link

In zx, the $ tagged template returns a Promise, not a stream. Therefore, installProcess.pipe(process.stdout) does not actually work as intended and will throw an error.

In zx, the $ tagged template returns a Promise, not a stream. Therefore, installProcess.pipe(process.stdout) does not actually work as intended and will throw an error.
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Promise Pipe Method Error

The buildProcess.pipe(process.stdout) call will throw a runtime error. buildProcess is a Promise returned by zx's $, and Promises don't have a .pipe() method. This is the same issue that was fixed for installProcess but remains here.

scripts/build-n8n.mjs#L103-L104

n8n/scripts/build-n8n.mjs

Lines 103 to 104 in c28c2b3

const buildProcess = $`cd ${config.rootDir} && pnpm build`;
buildProcess.pipe(process.stdout);

Fix in Cursor Fix in Web


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Oct 10, 2025
@n8n-assistant
Copy link

n8n-assistant bot commented Oct 10, 2025

Hey @vignesh1507,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following:
• Tests are included for any new functionality, logic changes or bug fixes.
• The PR aligns with our contribution guidelines.

Regarding new nodes:
We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach.

About review timelines:
This PR has been added to our internal tracker as "GHC-4960". While we plan to review it, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Thank you again for contributing to n8n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Authored by a community member in linear Issue or PR has been created in Linear for internal review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants