Skip to content

Conversation

mike12345567
Copy link
Contributor

@mike12345567 mike12345567 commented Oct 13, 2025

Summary

With the addition of the empty state to the builder side panel the opening of the panel had to be blocking. Since we load the messages when the panel opens we needed to know if there were messages to decide whether or not to show the empty state. This did however mean that the opening of the panel was blocking and could lead to some lag, it felt somewhat unpleasant.

To solve this, we now have a call to check if there are any messages currently for a workflow (endpoint POST /sessions/metadata) that occurs when the canvas/workflow loads. This means that we can open the panel immediately as we know whether or not we need to open the empty state already - messages can load in once they are available.

Ticket: https://linear.app/n8n/issue/AI-1525/t2w-add-loading-state-to-builder-side-panel

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@mike12345567 mike12345567 self-assigned this Oct 13, 2025
@mike12345567 mike12345567 changed the title fix: assistant side panel open without blocking calls (no-changelog) fix: Assistant side panel open without blocking calls (no-changelog) Oct 13, 2025
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 13, 2025
Copy link

bundlemon bot commented Oct 13, 2025

BundleMon

Files added (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
+181.26KB -
WASM Dependencies
tree-sitter.wasm
+74.47KB -

Total files change +255.73KB

Groups added (2)
Status Path Size Limits
**/*.js
+5.76MB -
**/*.css
+200.63KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/frontend/editor-ui/src/api/ai.ts">

<violation number="1" location="packages/frontend/editor-ui/src/api/ai.ts:122">
Rule violated: **Prefer Typeguards over Type casting**

Replace the new `as IDataObject` assertion on the request payload with a type annotation or `satisfies`-based check to comply with the &quot;Prefer Typeguards over Type casting&quot; guideline.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Copy link

codecov bot commented Oct 13, 2025

@mike12345567 mike12345567 requested review from a team and OlegIvaniv and removed request for a team October 13, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant