-
Notifications
You must be signed in to change notification settings - Fork 47.1k
chore: Update most secondary tokens #20724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BundleMonFiles added (2)
Total files change +255.73KB Groups added (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 181 files
Note: This PR contains a large number of files. cubic only reviews up to 150 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/frontend/@n8n/design-system/src/components/N8nSelectableList/SelectableList.vue">
<violation number="1" location="packages/frontend/@n8n/design-system/src/components/N8nSelectableList/SelectableList.vue:128">
The new CSS variable --ndv--color--background is not defined anywhere, so this change removes the selectable pill background (the variable resolves to nothing). Please switch to a defined token.</violation>
</file>
<file name="packages/frontend/@n8n/design-system/src/css/_primitives.scss">
<violation number="1" location="packages/frontend/@n8n/design-system/src/css/_primitives.scss:42">
Renaming the primary hue/saturation/light primitives adds an extra dash in the variable name, but deprecated tokens still reference the old identifiers, leaving them undefined and breaking all legacy primary color tokens.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
font-size: small; | ||
background-color: var(--color-ndv-background); | ||
color: var(--text-color-dark); | ||
background-color: var(--ndv--color--background); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new CSS variable --ndv--color--background is not defined anywhere, so this change removes the selectable pill background (the variable resolves to nothing). Please switch to a defined token.
Prompt for AI agents
Address the following comment on packages/frontend/@n8n/design-system/src/components/N8nSelectableList/SelectableList.vue at line 128:
<comment>The new CSS variable --ndv--color--background is not defined anywhere, so this change removes the selectable pill background (the variable resolves to nothing). Please switch to a defined token.</comment>
<file context>
@@ -125,13 +125,13 @@ function itemComparator(a: Item, b: Item) {
font-size: small;
- background-color: var(--color-ndv-background);
- color: var(--text-color-dark);
+ background-color: var(--ndv--color--background);
+ color: var(--color--text--shade-1);
</file context>
--p--color--primary-h: 7; | ||
--p--color--primary-s: 100%; | ||
--p--color--primary-l: 68%; | ||
--p--color--primary--h: 7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming the primary hue/saturation/light primitives adds an extra dash in the variable name, but deprecated tokens still reference the old identifiers, leaving them undefined and breaking all legacy primary color tokens.
Prompt for AI agents
Address the following comment on packages/frontend/@n8n/design-system/src/css/_primitives.scss at line 42:
<comment>Renaming the primary hue/saturation/light primitives adds an extra dash in the variable name, but deprecated tokens still reference the old identifiers, leaving them undefined and breaking all legacy primary color tokens.</comment>
<file context>
@@ -39,9 +39,9 @@
- --p--color--primary-h: 7;
- --p--color--primary-s: 100%;
- --p--color--primary-l: 68%;
+ --p--color--primary--h: 7;
+ --p--color--primary--s: 100%;
+ --p--color--primary--l: 68%;
</file context>
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)