fix(core): Prevent duplicate nodeExecuteBefore events for agent nodes #20726
+97
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix agent nodes showing stuck spinner due to duplicate nodeExecuteBefore events. When agents pause execution to run tools and then resume, they were emitting nodeExecuteBefore twice but nodeExecuteAfter only once, causing frontend execution tracking to become unbalanced. Solution: Skip nodeExecuteBefore hook when agent node resumes after tool execution by setting and checking nodeWasResumed metadata flag. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
despairblue
force-pushed
the
ai-1414-agent-incorrectly-displays-executing-state-after-using-tools
branch
from
427ab57 to
6e29a97
Compare
n8n-assistant
bot
added
core
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes agent nodes showing stuck spinner in the UI due to duplicate
nodeExecuteBeforeevents.Problem: When AI agent nodes pause execution to run tool nodes and then resume with tool results, they were emitting
nodeExecuteBeforetwice (initial + resume) butnodeExecuteAfteronly once. This caused the frontend's execution tracking queue to become unbalanced, leaving spinners stuck in "executing" state.AI-1414-before.mp4
Solution: Skip the
nodeExecuteBeforehook when an agent node resumes execution after tool completion by setting and checking anodeWasResumedmetadata flag.AI-1414-after.mp4
Key changes:
nodeWasResumedflag toITaskMetadatainterface (optional for backward compatibility)handleRequest()inrequests-response.tsto setnodeWasResumed: truewhen re-scheduling agent nodeworkflow-execute.tsto skipnodeExecuteBeforehook ifnodeWasResumedis truenodeWasResumedandpreserveSourceOverwritepropertiesRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-1414
Review / Merge checklist
Docs updated or follow-up ticket createdPR Labeled withrelease/backport(if urgent fix needed)