-
Notifications
You must be signed in to change notification settings - Fork 47.1k
test: Add tests for firebase node (no-changelog) #20732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 5. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/nodes-base/nodes/Google/Firebase/CloudFirestore/__test__/GenericFunctions.test.ts">
<violation number="1" location="packages/nodes-base/nodes/Google/Firebase/CloudFirestore/__test__/GenericFunctions.test.ts:237">
The test for `googleApiRequestAllItems` is skipped, but the underlying function in `RealtimeDatabase/GenericFunctions.ts` contains incorrect pagination logic (using `pageToken`) for Realtime Database. This appears to be a copy-paste error from the Firestore implementation, leaving a broken utility function untested.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
// Tests for googleApiRequestAllItems are skipped as they require complex internal mocking | ||
// The function logic is simple pagination handling that wraps googleApiRequest | ||
// These tests would be better suited as integration tests rather than unit tests | ||
it('should be tested with integration tests', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test for googleApiRequestAllItems
is skipped, but the underlying function in RealtimeDatabase/GenericFunctions.ts
contains incorrect pagination logic (using pageToken
) for Realtime Database. This appears to be a copy-paste error from the Firestore implementation, leaving a broken utility function untested.
Prompt for AI agents
Address the following comment on packages/nodes-base/nodes/Google/Firebase/CloudFirestore/__test__/GenericFunctions.test.ts at line 237:
<comment>The test for `googleApiRequestAllItems` is skipped, but the underlying function in `RealtimeDatabase/GenericFunctions.ts` contains incorrect pagination logic (using `pageToken`) for Realtime Database. This appears to be a copy-paste error from the Firestore implementation, leaving a broken utility function untested.</comment>
<file context>
@@ -0,0 +1,566 @@
+ // Tests for googleApiRequestAllItems are skipped as they require complex internal mocking
+ // The function logic is simple pagination handling that wraps googleApiRequest
+ // These tests would be better suited as integration tests rather than unit tests
+ it('should be tested with integration tests', () => {
+ expect(true).toBe(true); // Placeholder to avoid empty describe block
+ });
</file context>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
WIP
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3783/use-ai-to-add-nodes-tests
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)