-
Notifications
You must be signed in to change notification settings - Fork 50.8k
feat: Pagination with Reka #22222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Pagination with Reka #22222
Conversation
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 issues found across 6 files
Prompt for AI agents (all 5 issues)
Understand the root cause of the following 5 issues and fix them.
<file name="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/component-pagination.md">
<violation number="1" location="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/component-pagination.md:33">
Both Pagination examples use `ref` in `<script setup>` without importing it, so the snippets throw `ref is not defined` when copied into a Vue component. Add `import { ref } from 'vue'` at the top of each example block.</violation>
</file>
<file name="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts">
<violation number="1" location="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts:61">
`should not render ellipsis for small page counts` never inspects the ellipsis character, so it cannot catch the regression it claims to cover.</violation>
<violation number="2" location="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts:134">
`should update current page when clicking next button` never fails when the next button is missing because the entire assertion block is wrapped in `if (nextButton)`, so the test silently does nothing if the component regresses.</violation>
<violation number="3" location="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts:157">
`should update current page when clicking prev button` also guards the entire test with `if (prevButton)`, so the test passes even when the prev button is not rendered and therefore never validates the behavior.</violation>
</file>
<file name="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.vue">
<violation number="1" location="packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.vue:26">
`page` is never synced when `currentPage` prop changes, so the active pagination state drifts whenever the parent updates the prop programmatically. Mirror prop updates into the local ref (e.g., via a watch/computed) so highlighting and internal state stay in sync.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/component-pagination.md
Outdated
Show resolved
Hide resolved
packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts
Show resolved
Hide resolved
packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts
Outdated
Show resolved
Hide resolved
packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.test.ts
Outdated
Show resolved
Hide resolved
packages/frontend/@n8n/design-system/src/v2/components/N8nPagination/Pagination.vue
Show resolved
Hide resolved
|
E2E Tests: n8n tests passed after 8m 46.5s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Summary
Related Linear tickets, Github issues, and Community forum posts
DES-321
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)