chore(editor): DropdownMenu component specs (no-changelog) #22229
+259
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/frontend/@n8n/design-system/src/v2/components/DropdownMenu/component-dropdown-menu.md">
<violation number="1" location="packages/frontend/@n8n/design-system/src/v2/components/DropdownMenu/component-dropdown-menu.md:106">
The “With badges and shortcuts” example listens for `@select="handleSelect"` even though no `handleSelect` function is declared in the script block, so the example won’t run as written.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| <template> | ||
| <N8nDropdownMenu | ||
| :items="dropdownItems" | ||
| @select="handleSelect" |
Contributor
There was a problem hiding this comment.
The “With badges and shortcuts” example listens for @select="handleSelect" even though no handleSelect function is declared in the script block, so the example won’t run as written.
Prompt for AI agents
Address the following comment on packages/frontend/@n8n/design-system/src/v2/components/DropdownMenu/component-dropdown-menu.md at line 106:
<comment>The “With badges and shortcuts” example listens for `@select="handleSelect"` even though no `handleSelect` function is declared in the script block, so the example won’t run as written.</comment>
<file context>
@@ -0,0 +1,259 @@
+<template>
+ <N8nDropdownMenu
+ :items="dropdownItems"
+ @select="handleSelect"
+ />
+</template>
</file context>
|
E2E Tests: n8n tests passed after 9m 22.3s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
API specification for new design system component,
DropdownMenuthat should replaceActionToggleandActionDropdownRelated Linear tickets, Github issues, and Community forum posts
Closes ADO-4384
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)