-
Notifications
You must be signed in to change notification settings - Fork 50.8k
feat(core): Use personal projects for chat hub executions (no-changelog) #22231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(core): Use personal projects for chat hub executions (no-changelog) #22231
Conversation
… on chat hub (no-changelog)
…/admin users (no-changelog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/cli/src/modules/chat-hub/chat-hub-credentials.service.ts">
<violation number="1" location="packages/cli/src/modules/chat-hub/chat-hub-credentials.service.ts:62">
Rule violated: **Tests**
No tests cover the newly added `ensureWorkflowCredentials` flow that now enforces project-scoped credential access, violating the Community PR Guidelines requirement to add tests for new core functionality.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
This comment has been minimized.
This comment has been minimized.
|
E2E Tests: n8n tests passed after 12m 9.6s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Summary
Use user's personal project as the project context for chat hub executions. Only list credentials usable in the personal project, except for owners / instance admins list all credentials as they can be used in those user's personal projects..
n8n workflow agents are still executed in their own project context.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CHA-61
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)