Skip to content

Conversation

@Cadiac
Copy link
Contributor

@Cadiac Cadiac commented Nov 24, 2025

Summary

Use user's personal project as the project context for chat hub executions. Only list credentials usable in the personal project, except for owners / instance admins list all credentials as they can be used in those user's personal projects..

n8n workflow agents are still executed in their own project context.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CHA-61

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 24, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/cli/src/modules/chat-hub/chat-hub-credentials.service.ts">

<violation number="1" location="packages/cli/src/modules/chat-hub/chat-hub-credentials.service.ts:62">
Rule violated: **Tests**

No tests cover the newly added `ensureWorkflowCredentials` flow that now enforces project-scoped credential access, violating the Community PR Guidelines requirement to add tests for new core functionality.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@Cadiac Cadiac requested a review from autologie November 24, 2025 15:11
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tures/ai/chatHub/composables/useChatCredentials.ts 0.00% 23 Missing ⚠️
...c/modules/chat-hub/chat-hub-credentials.service.ts 92.30% 0 Missing and 2 partials ⚠️
...kages/cli/src/modules/chat-hub/chat-hub.service.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@bundlemon
Copy link

bundlemon bot commented Nov 24, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
11.38MB (+94.75KB +0.82%) -
**/*.css
231.53KB (+10.76KB +4.87%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@blacksmith-sh

This comment has been minimized.

@currents-bot
Copy link

currents-bot bot commented Nov 24, 2025

E2E Tests: n8n tests passed after 12m 9.6s

🟢 588 · 🔴 0 · ⚪️ 12 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 2650154

  • Spec files: 96

  • Overall tests: 600

  • Duration: 12m 9.6s

  • Parallelization: 9

Groups

GroupId Results Spec Files Progress
ui 🟢 539 · 🔴 0 · ⚪️ 12 90 / 90
ui:isolated 🟢 49 · 🔴 0 · ⚪️ 0 · 🟣 2 6 / 6


This message was posted automatically by currents.dev | Integration Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants