-
Notifications
You must be signed in to change notification settings - Fork 50.8k
fix(editor): Allow running webhook workflow even when a node has error #22239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(editor): Allow running webhook workflow even when a node has error #22239
Conversation
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
|
Found 1 test failure on Blacksmith runners: Failure
|
Summary
This pull request addresses a bug that prevented workflows from running when unconnected nodes had errors, particularly in scenarios involving webhook triggers. The main changes ensure that workflows can still execute and wait for webhook events even if there are issues with connected/unconnected nodes, and a new test verifies this behavior.
Bug fix for workflow execution with unconnected node errors:
useRunWorkflow.ts).Testing improvements:
16-webhook-node.spec.ts).Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1253/bug-cant-run-workflow-when-unconnected-nodes-have-errors
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)