Skip to content

Conversation

@alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Nov 24, 2025

Summary

This pull request addresses a bug that prevented workflows from running when unconnected nodes had errors, particularly in scenarios involving webhook triggers. The main changes ensure that workflows can still execute and wait for webhook events even if there are issues with connected/unconnected nodes, and a new test verifies this behavior.

Bug fix for workflow execution with unconnected node errors:

  • Removed the check that blocked workflow execution when there were issues in unconnected nodes, allowing workflows to proceed to the webhook waiting state regardless of such errors (useRunWorkflow.ts).

Testing improvements:

  • Added a Playwright test to verify that workflows with unconnected nodes containing errors (e.g., an unconnected HTTP Request node) can still execute and wait for a webhook trigger without showing an error notification (16-webhook-node.spec.ts).

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-1253/bug-cant-run-workflow-when-unconnected-nodes-have-errors

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Nov 24, 2025
@bundlemon
Copy link

bundlemon bot commented Nov 24, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
11.38MB (+94.45KB +0.82%) -
**/*.css
231.53KB (+10.76KB +4.87%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Nov 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
14780 1 14779 0
View the top 1 failed test(s) by shortest run time
ActiveExecutions shutdown Should cancel all executions when cancelAll is true
Stack Traces | 0.002s run time
Error: expect(received).toHaveLength(expected)

Expected length: 4
Received length: 3
Received array:  [{"id": "1459", "mode": "manual", "retryOf": undefined, "startedAt": 2025-11-24T15:06:07.645Z, "status": "new", "workflowId": "123"}, {"id": "1604", "mode": "manual", "retryOf": undefined, "startedAt": 2025-11-24T15:06:07.645Z, "status": "waiting", "workflowId": "123"}, {"id": "1874", "mode": "manual", "retryOf": undefined, "startedAt": 2025-11-24T15:06:07.645Z, "status": "waiting", "workflowId": "123"}]
    at Object.<anonymous> (.../src/__tests__/active-executions.test.ts:369:51)
    at Promise.then.completed (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/utils.js:300:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/utils.js:233:10)
    at _callCircusTest (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/run.js:315:40)
    at _runTest (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/run.js:251:3)
    at _runTestsForDescribeBlock (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/run.js:125:9)
    at _runTestsForDescribeBlock (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/run.js:120:9)
    at _runTestsForDescribeBlock (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/run.js:120:9)
    at run (.../n8n/node_modules/.pnpm/[email protected]..../jest-circus/build/run.js:70:3)
    at runAndTransformResultsToJestFormat (.../n8n/node_modules/.pnpm/[email protected]..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../n8n/node_modules/.pnpm/[email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../n8n/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../n8n/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../n8n/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Nov 24, 2025
@blacksmith-sh
Copy link

blacksmith-sh bot commented Nov 24, 2025

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
ActiveExecutions/
ActiveExecutions shutdown Should cancel all executions when cancelAll is true
View Logs


Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants