ci: Fix excessively deep type instantiation in ChatHubMessageRepository
#22240
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
commented
Nov 24, 2025
| async createChatMessage(message: Partial<ChatHubMessage>, trx?: EntityManager) { | ||
| async createChatMessage(message: QueryDeepPartialEntity<ChatHubMessage>, trx?: EntityManager) { | ||
| const messageId = message.id; | ||
| if (typeof messageId === 'function') { |
Member
Author
There was a problem hiding this comment.
The check is needed because QueryDeepPartialEntity allows every property to be either a value or (() => string) for SQL functions like NOW().
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
|
E2E Tests: n8n tests passed after 9m 16s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
mike12345567
approved these changes
Nov 24, 2025
Contributor
mike12345567
left a comment
mike12345567
left a comment
There was a problem hiding this comment.
LGTM - fixes the issue for me locally!
ivov
deleted the
ci-fix-TypeScript-excessively-deep-type-instantiation-in-chat-hub-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatHubMessagehas self-referencing bidirectional relations and, depending on the cache state, typechecking it may lead to TS2589. This fails specifically onentityManager.insertwhose arg type was fixed to break cycles, which indeed stopped them until now, so one theory is that TS is expanding self-references on checking assignability ofPartial<ChatHubMessage>(feature type) toQueryDeepPartialEntity<ChatHubMessage>(typeorm type).Let's validate the theory by aligning the types.