feat(core): Draft/Publish workflow endpoints follow up (no-changelog)

[dariacodes]

Summary

• activate workflow now sets active version id to the current active version in case of errors during activation and populates the active version for return data
• get workflow endpoint now populates active version for return data

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-4459/feature-be-workflow-endpoints-follow-up

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/cli/src/workflows/workflow.service.ts	66.66%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/cli/src/workflows/workflow.service.ts">

<violation number="1" location="packages/cli/src/workflows/workflow.service.ts:490">
Activation failures now emit a `workflow-deactivated` event even when the workflow stays active, because the rollback payload can set `active` back to true. Condition the event emission on the rollback state so listeners aren’t told the workflow deactivated when it didn’t.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

[cubic-dev-ai]

Activation failures now emit a workflow-deactivated event even when the workflow stays active, because the rollback payload can set active back to true. Condition the event emission on the rollback state so listeners aren’t told the workflow deactivated when it didn’t.

Prompt for AI agents

Address the following comment on packages/cli/src/workflows/workflow.service.ts at line 490:

<comment>Activation failures now emit a `workflow-deactivated` event even when the workflow stays active, because the rollback payload can set `active` back to true. Condition the event emission on the rollback state so listeners aren’t told the workflow deactivated when it didn’t.</comment>

<file context>
@@ -457,37 +471,25 @@ export class WorkflowService {
-			workflow.active = false;
-			workflow.activeVersionId = null;
-			workflow.activeVersion = null;
+			workflow.active = rollbackPayload.active;
+			workflow.activeVersionId = rollbackPayload.activeVersionId;
+			workflow.activeVersion = rollbackPayload.activeVersion;
</file context>

✅ Addressed in 836dfe8

[currents-bot]

✅

E2E Tests: n8n tests passed after 11m 5.6s

🟢 588 · 🔴 0 · ⚪️ 12 · 🟣 5

View Run Details

Run Details

• Project: n8n

• Groups: 2

• Framework: Playwright

• Run Status: Passed

• Commit: 836dfe8

• Spec files: 96

• Overall tests: 600

• Duration: 11m 5.6s

• Parallelization: 9

Groups

GroupId	Results	Spec Files Progress
ui	🟢 539 · 🔴 0 · ⚪️ 12 · 🟣 4	90 / 90
ui:isolated	🟢 49 · 🔴 0 · ⚪️ 0 · 🟣 1	6 / 6

---

This message was posted automatically by currents.dev | Integration Settings