feat: Add banner enhancemenets #23952
Draft
+139
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 5m 33.1s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
endor
reviewed
Jan 7, 2026
| await this.workflowRepository.updateActiveState(workflowId, false); | ||
|
|
||
| // Store auto-deactivation metadata | ||
| const autoDeactivatedAt = new Date().toISOString(); |
Contributor
There was a problem hiding this comment.
I remember we explicitly left this out of our last PR due to concerns over database activity. @ivov is this still a concern?
endor
reviewed
Jan 7, 2026
| }); | ||
| const isAutoDeactivated = computed(() => { | ||
| return !!props.data.meta?.autoDeactivatedAt && !props.data.active; |
Contributor
There was a problem hiding this comment.
Should we use isWorkflowPublished instead of checking props.data.active here?
endor
reviewed
Jan 7, 2026
|
|
||
| // Store auto-deactivation metadata | ||
| const autoDeactivatedAt = new Date().toISOString(); | ||
| await this.workflowRepository.update(workflowId, { |
Contributor
There was a problem hiding this comment.
I also wonder, should we have any sort of telemetry about how (often) this feature is used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)