-
Notifications
You must be signed in to change notification settings - Fork 53.3k
refactor: Separate storybook from design-system (no-changelog) #23983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 24 files
autologie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One wish item, but overall looks good.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 8m 1.4s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/frontend/@n8n/storybook/package.json">
<violation number="1" location="packages/frontend/@n8n/storybook/package.json:15">
P2: `vue-tsc` is a development-only type-checking tool and should not be in `dependencies`. Additionally, it's duplicated here since it already exists in `devDependencies` with version `^3.1.4`. Remove this line and update the existing devDependencies entry to use `catalog:frontend` if that's the intended version.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 7 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/frontend/@n8n/chat/tsconfig.json">
<violation number="1">
P2: Story files still exist in this package (e.g., `src/__stories__/App.stories.ts`) but will now be included in TypeScript compilation since the exclude pattern was removed. Consider keeping the exclude or moving story files to the new `@n8n/storybook` package to prevent them from being compiled with the chat package's production build.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary
This pull request migrates Storybook configuration and build processes for the
@n8n/design-systemand@n8n/chatpackages into a new, dedicated@n8n/storybookworkspace package. The changes centralize Storybook setup, update dependencies, and clean up package scripts and configuration files, resulting in a more maintainable and unified Storybook environment for both frontend packages.Storybook workspace migration and configuration:
packages/frontend/@n8n/storybookpackage with its ownpackage.json, Storybook configuration (.storybook/main.ts,preview.ts,fonts.scss,storybook.scss), and supporting files, consolidating Storybook setup for both@n8n/design-systemand@n8n/chatcomponents. [1] [2] [3] [4] [5] [6] [7]design-systemandchat, and updated static asset paths. [1] [2] [3]Cleanup and removal from
@n8n/design-systemand@n8n/chat:@n8n/design-systemand@n8n/chat, including.storybookdirectories, related scripts inpackage.json, and unnecessary dependencies on@n8n/storybook. [1] [2] [3] [4] F7333bdbL1, [5] [6] [7] [8] [9]CI/CD workflow updates:
@n8n/storybookpackage instead of@n8n/design-system, and to trigger on changes to both@n8n/design-systemand@n8n/chat. [1] [2] [3]Miscellaneous improvements:
@n8n/design-system(var(-color-info)→var(--color--info))..gitignoreto the new Storybook package to exclude logs, build output, and editor files.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-2071/separate-storybook-from-design-system
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)