Skip to content

Conversation

@alexgrozav
Copy link
Member

Summary

This pull request migrates Storybook configuration and build processes for the @n8n/design-system and @n8n/chat packages into a new, dedicated @n8n/storybook workspace package. The changes centralize Storybook setup, update dependencies, and clean up package scripts and configuration files, resulting in a more maintainable and unified Storybook environment for both frontend packages.

Storybook workspace migration and configuration:

  • Created a new packages/frontend/@n8n/storybook package with its own package.json, Storybook configuration (.storybook/main.ts, preview.ts, fonts.scss, storybook.scss), and supporting files, consolidating Storybook setup for both @n8n/design-system and @n8n/chat components. [1] [2] [3] [4] [5] [6] [7]
  • Updated Storybook configuration to use new absolute import resolution, include stories from both design-system and chat, and updated static asset paths. [1] [2] [3]
  • Upgraded Storybook and related dependencies to v10, and removed deprecated or unused addons and scripts.

Cleanup and removal from @n8n/design-system and @n8n/chat:

  • Removed local Storybook configuration files and scripts from @n8n/design-system and @n8n/chat, including .storybook directories, related scripts in package.json, and unnecessary dependencies on @n8n/storybook. [1] [2] [3] [4] F7333bdbL1, [5] [6] [7] [8] [9]
  • Adjusted story titles and imports to reflect the new centralized Storybook structure. [1] [2]

CI/CD workflow updates:

  • Updated the Storybook GitHub Actions workflow to build and deploy from the new @n8n/storybook package instead of @n8n/design-system, and to trigger on changes to both @n8n/design-system and @n8n/chat. [1] [2] [3]

Miscellaneous improvements:

  • Fixed a typo in a SCSS variable in @n8n/design-system (var(-color-info)var(--color--info)).
  • Added a .gitignore to the new Storybook package to exclude logs, build output, and editor files.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-2071/separate-storybook-from-design-system

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav requested a review from autologie January 7, 2026 14:06
@alexgrozav alexgrozav self-assigned this Jan 7, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 7, 2026
Copy link
Contributor

@autologie autologie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wish item, but overall looks good.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../frontend/@n8n/chat/src/__stories__/App.stories.ts 0.00% 1 Missing ⚠️
...ponents/DateRangePicker/DateRangePicker.stories.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@currents-bot
Copy link

currents-bot bot commented Jan 7, 2026

E2E Tests: n8n tests passed after 8m 1.4s

🟢 609 · 🔴 0 · ⚪️ 38 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 256e698

  • Spec files: 142

  • Overall tests: 647

  • Duration: 8m 1.4s

  • Parallelization: 16

Groups

GroupId Results Spec Files Progress
multi-main:e2e:isolated 🟢 57 · 🔴 0 · ⚪️ 0 9 / 9
multi-main:e2e 🟢 552 · 🔴 0 · ⚪️ 38 · 🟣 2 133 / 133


This message was posted automatically by currents.dev | Integration Settings

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/frontend/@n8n/storybook/package.json">

<violation number="1" location="packages/frontend/@n8n/storybook/package.json:15">
P2: `vue-tsc` is a development-only type-checking tool and should not be in `dependencies`. Additionally, it's duplicated here since it already exists in `devDependencies` with version `^3.1.4`. Remove this line and update the existing devDependencies entry to use `catalog:frontend` if that's the intended version.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/frontend/@n8n/chat/tsconfig.json">

<violation number="1">
P2: Story files still exist in this package (e.g., `src/__stories__/App.stories.ts`) but will now be included in TypeScript compilation since the exclude pattern was removed. Consider keeping the exclude or moving story files to the new `@n8n/storybook` package to prevent them from being compiled with the chat package's production build.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants