-
Notifications
You must be signed in to change notification settings - Fork 53.3k
feat(core): Support disabling publishing workflows in personal space (no-changelog) #23985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(core): Support disabling publishing workflows in personal space (no-changelog) #23985
Conversation
In the case where an admin has disabled publishing from the personal space, we don't want this scope being added back to the project:personalOwner role by the syncing logic.
❌ 17 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Found 17 test failures on Blacksmith runners: Failures
|
|
E2E Tests: n8n tests passed after 7m 49.9s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
| private readonly roleService: RoleService, | ||
| ) {} | ||
|
|
||
| async setPersonalSpacePublishing(enabled: boolean): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a call with @afitzek: here we need to add a call to RoleCacheService.refreschCache
Summary
THIS PR IS JUST A PROOF OF CONCEPT AND LOTS OF CODE WAS GENERATED WITH CLAUDE, NOT READY FOR PRODUCTIVE USE.
Adds two new endpoints:
These endpoints allow to fetch and change the value of the new
personalSpacePublishing: booleansetting.Adds a new route under
/settings/securityto interact with the new endpoint for controlling whether users can publish workflows from their personal space.Enable feature flag
060_personal_project_governanceto access the route.When this setting is disabled, this member user can no longer publish personal workflows:
Related Linear tickets, Github issues, and Community forum posts
PAY-4331
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)