-
Notifications
You must be signed in to change notification settings - Fork 53.3k
feat(editor): Show building and done status in page title for AI builder #23987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Show building and done status in page title for AI builder #23987
Conversation
0a68112 to
06a2a53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 6 files
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 7m 29.8s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
06a2a53 to
b80f92f
Compare
mutdmour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job
| icon = '▶️'; | ||
| prefix = '▶️'; | ||
| } else if (status === 'AI_BUILDING') { | ||
| prefix = '[Building]'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of how inconsistent the naming is
packages/frontend/editor-ui/src/features/ai/assistant/builder.store.ts
Outdated
Show resolved
Hide resolved
packages/frontend/editor-ui/src/features/ai/assistant/components/Agent/AskAssistantBuild.vue
Show resolved
Hide resolved
…he building status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/frontend/editor-ui/src/app/views/NodeView.test.ts">
<violation number="1" location="packages/frontend/editor-ui/src/app/views/NodeView.test.ts:29">
P2: Tests are tautological - they test inline if/else logic rather than the actual implementation. The file claims to test NodeView but never imports it, and references a non-existent `openWorkflow` function. The actual streaming/title logic lives in `builder.store.ts` (`prepareForStreaming`, `stopStreaming`). Consider either importing and testing the actual store methods, or removing these tests if builder.store.test.ts already covers this functionality.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
mutdmour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing my feedback
Linear ticket related: https://linear.app/n8n/issue/AI-1811/feature-change-title-of-browser-tab-and-add-icon-to-indicate-build
Summary
Adds visual feedback in the browser tab title when the AI builder is working or has completed, helping users who switch tabs know the status of their workflow generation.
Changes
New behavior
[Building]prefix appears in the page title while the AI builder is generating[Done]prefix appears when the AI builder finishes, only if the user is on another tabHow it works
sendChatMessageis called → title shows[Building] Workflow Name - n8n- If tab is hidden → title shows
[Done] Workflow Name - n8n- If tab is visible → title shows
▶️ Workflow Name - n8n (IDLE)Test plan
useDocumentTitlewith all status typesbuilder.storetitle behaviorDemo
Building on AI builder starting

IDLE on finishing and tab is focused

Moves to Done on finishing and you don't have the tab focused

Resets to IDLE on focusing the tab,
Doneotherwise