fix(core): Sanitize filenames for file operations

[DawidMyslak]

Summary

Improve sanitization for file names.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4175/

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[cubic-dev-ai]

1 issue found across 6 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/nodes-base/nodes/Ssh/Ssh.node.ts">

<violation number="1" location="packages/nodes-base/nodes/Ssh/Ssh.node.ts:452">
P1: Using `??` instead of `||` causes a regression: when `fileName` is an empty string (the default from `getNodeParameter`), it won't fall back to `binaryData.fileName`. The `??` operator only coalesces `null`/`undefined`, not empty strings. This will result in uploads to paths like `/home/user/` instead of `/home/user/filename.txt`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[codecov]

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/nodes-base/nodes/Ssh/Ssh.node.ts	0.00%	3 Missing ⚠️
...execution-context/utils/binary-helper-functions.ts	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[currents-bot]

✅

E2E Tests: n8n tests passed after 12m 41.8s

🟢 609 · 🔴 0 · ⚪️ 38 · 🟣 3

View Run Details

Run Details

• Project: n8n

• Groups: 2

• Framework: Playwright

• Run Status: Passed

• Commit: cae3955

• Spec files: 142

• Overall tests: 647

• Duration: 12m 41.8s

• Parallelization: 16

Groups

GroupId	Results	Spec Files Progress
multi-main:e2e	🟢 552 · 🔴 0 · ⚪️ 38 · 🟣 1	133 / 133
multi-main:e2e:isolated	🟢 57 · 🔴 0 · ⚪️ 0 · 🟣 2	9 / 9

---

This message was posted automatically by currents.dev | Integration Settings