Skip to content

Conversation

@mike12345567
Copy link
Contributor

@mike12345567 mike12345567 commented Jan 7, 2026

Summary

Current behaviour has workflow builder generation saving multiple times throughout the generation when the workflow is an unfinished state. This PR disables saving while generation is streaming.

I've also removed all of the logic related to saving after the workflow builder has finished as auto-save can now look after this instead - currently two saves occur at the end as auto-save detects the changes and the workflow builder triggers a save.

Addresses: https://linear.app/n8n/issue/AI-1878/feature-stop-auto-saving-when-builder-is-in-progress

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

…to-save, and disabling auto-save functionality when generation is occurring.
@mike12345567 mike12345567 self-assigned this Jan 7, 2026
@mike12345567 mike12345567 requested a review from mutdmour January 7, 2026 16:04
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 7, 2026
@mike12345567 mike12345567 changed the title fix(ai-builder): Disable autosave functionality while workflow builder is generating fix(ai-builder): Disable autosave functionality while workflow builder is generating (no-changelog) Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...collaboration/collaboration/collaboration.store.ts 66.66% 2 Missing ⚠️
...i/assistant/components/Agent/AskAssistantBuild.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@currents-bot
Copy link

currents-bot bot commented Jan 7, 2026

E2E Tests: n8n tests passed after 7m 35s

🟢 55 · 🔴 0 · ⚪️ 3

View Run Details

Run Details

  • Project: n8n

  • Groups: 1

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 0bfcc39

  • Spec files: 10

  • Overall tests: 58

  • Duration: 7m 35s

  • Parallelization: 1


This message was posted automatically by currents.dev | Integration Settings

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation here looks okay. Some new tests would be nice.

But I think there's a missing piece.

the new collaboration feature adds a write lock while the user is actively working on a workflow. The workflow is locked for 20 seconds if user is inactive.

The builder does not seem to have any effect on this. When sending a message, a write lock is requested. 20 seconds later the lock is released, even while the builder is working away.

That could lead to conflicts if another user acquires the lock while the builder is working for another user.
Ideally the UI should keep the write lock while the builder is toiling away.

Screenshot 2026-01-08 at 12 11 36

@mike12345567 mike12345567 requested a review from mutdmour January 8, 2026 14:16
@blacksmith-sh

This comment has been minimized.

@mike12345567 mike12345567 merged commit 163f177 into ado-4284-autosave-collaboration Jan 8, 2026
68 of 70 checks passed
@mike12345567 mike12345567 deleted the ai-1871-disable-autosave-when-wfb-generating branch January 8, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants