-
Notifications
You must be signed in to change notification settings - Fork 53.3k
fix(ai-builder): Disable autosave functionality while workflow builder is generating (no-changelog) #23989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ai-builder): Disable autosave functionality while workflow builder is generating (no-changelog) #23989
Conversation
…to-save, and disabling auto-save functionality when generation is occurring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 7m 35s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
mutdmour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation here looks okay. Some new tests would be nice.
But I think there's a missing piece.
the new collaboration feature adds a write lock while the user is actively working on a workflow. The workflow is locked for 20 seconds if user is inactive.
The builder does not seem to have any effect on this. When sending a message, a write lock is requested. 20 seconds later the lock is released, even while the builder is working away.
That could lead to conflicts if another user acquires the lock while the builder is working for another user.
Ideally the UI should keep the write lock while the builder is toiling away.
This comment has been minimized.
This comment has been minimized.
163f177
into
ado-4284-autosave-collaboration
Summary
Current behaviour has workflow builder generation saving multiple times throughout the generation when the workflow is an unfinished state. This PR disables saving while generation is streaming.
I've also removed all of the logic related to saving after the workflow builder has finished as auto-save can now look after this instead - currently two saves occur at the end as auto-save detects the changes and the workflow builder triggers a save.
Addresses: https://linear.app/n8n/issue/AI-1878/feature-stop-auto-saving-when-builder-is-in-progress
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)